Skip to content

fix: wrong bloom filter max size bits #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
proost merged 1 commit into from
Feb 13, 2026
Merged

fix: wrong bloom filter max size bits #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions filters/bloom_filter_builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,15 @@ import (
"encoding/binary"
"fmt"
"math"

"github.com/apache/datasketches-go/internal"
)

// Default seed value for hash functions
// DefaultSeed is the default seed value for hash functions
const DefaultSeed = uint64(9001)

var maxBits = uint64((math.MaxInt32 - internal.FamilyEnum.BloomFilter.MaxPreLongs) * 64)

// bloomFilterOptions holds optional parameters for filter construction.
type bloomFilterOptions struct {
seed uint64
Expand Down Expand Up @@ -59,7 +63,6 @@ func NewBloomFilterBySize(numBits uint64, numHashes uint16, opts ...BloomFilterO
}

// Check for overflow
maxBits := uint64(math.MaxInt32-32) * 64
if numBits > maxBits {
return nil, fmt.Errorf("numBits exceeds maximum allowed size")
}
Expand Down
4 changes: 4 additions & 0 deletions filters/bloom_filter_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ func TestInvalidConstructorArguments(t *testing.T) {
_, err = NewBloomFilterBySize(1<<60, 3)
assert.Error(t, err)

// numBits exceeds maxBits by 1
_, err = NewBloomFilterBySize(maxBits+1, 3)
assert.ErrorContains(t, err, "numBits exceeds maximum allowed size")

// Invalid FPP
_, err = NewBloomFilterByAccuracy(1000, 0.0)
assert.Error(t, err)
Expand Down
Loading