Skip to content

Conversation

@bdemers
Copy link
Member

@bdemers bdemers commented Sep 12, 2025

Deprecate old method, new method falls back to previous

Wart, implementors must still implement the old method

Deprecate old method, new method falls back to previous

Wart, implementors must still implement the old method
@github-actions
Copy link

View details about the 'Apache Rat - Check' build 533 in the Build Scan 📊

@github-actions
Copy link

View details about the 'Maven Verify (with Java 21-zulu)' build 1668 in the Build Scan 📊

@github-actions
Copy link

View details about the 'Maven Verify (with Java 17-zulu)' build 1668 in the Build Scan 📊

@bdemers
Copy link
Member Author

bdemers commented Sep 12, 2025

@CS-Birb I took a quick pass at replacing the attribute args with a ScimRequestContext
(just the create method at first to get a feel for how it would look, but the rest of the methods would need to be implemented before merging)

I think this could work, but I don't like my fall back strategy (default method, calls the old method). Implementors would need to implement the new method, and the old, which feel wrong.

Any thoughts?

@CS-Birb
Copy link
Contributor

CS-Birb commented Sep 15, 2025

I'd struggled to think of an ideal fallback strategy with my previous PR too. Bit of a catch-22.

Making the new method default has the lowest impact for existing implementations of the Repository, but to use the new method will require keeping an override for the old.

Between M1 and the next production release there are already breaking changes in the Repository method signatures (I.e. version string to ETags, attribute references in more methods) so this may be a viable time to implement this as a breaking change.
Adding new fields later on to the ScimRequestContext could then only be minor changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants