Skip to content

[Fix-17389] Fix JSONUtils to support nested JSON objects #17888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ujwalsingh-190 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[Fix-17389] Fix JSONUtils to support nested JSON objects #17888

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion ...hinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
import java.util.Collections;
import java.util.List;
import java.util.Map;
import java.util.HashMap;
import java.util.Objects;
import java.util.TimeZone;

Expand Down Expand Up @@ -248,10 +249,21 @@ public static String findValue(JsonNode jsonNode, String fieldName) {
* @return json to map
*/
public static Map<String, String> toMap(String json) {
return parseObject(json, new TypeReference<Map<String, String>>() {
Map<String, Object> map = parseObject(json, new TypeReference<Map<String, Object>>() {
Copy link
Member

@ruanwenjun ruanwenjun Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method is used in many places, and this modification may cause more serious problems, you need to use parseObject at the upper layer.

Copy link
Author

@Ujwalsingh-190 Ujwalsingh-190 Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review and suggestion. I understand the concern about modifying this common utility method. I will revert this change and move the parsing logic to the upper layer where it is needed. I’ll update the PR accordingly.

});

if (map == null) {
return Collections.emptyMap();
}

Map<String, String> result = new HashMap<>();
for (Map.Entry<String, Object> entry : map.entrySet()) {
result.put(entry.getKey(), String.valueOf(entry.getValue()));
}
return result;
}


/**
* from the key-value generated json to get the str value no matter the real type of value
*
Expand Down
Loading