[Improvement-17908][Flink] Make -sae parameter configurable in UI with default off #17909
+104
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent task termination The -sae (--shutdownOnAttachedExit) parameter is only suitable for attached mode where the CLI stays connected and waits for the job to complete. However, YARN Application mode runs in detached mode where the CLI exits after submission, causing the -sae parameter to trigger cluster shutdown and terminate the job unexpectedly. Changes: - Only add -sae parameter for non-APPLICATION deploy modes - Update test cases to reflect the new behavior
chris-fast
requested review from
Gallardot,
SbloodyS and
caishunfeng
as code owners
SbloodyS
requested changes
Jan 27, 2026
Comment on lines
270
to
273
| // Note: -sae should NOT be used for APPLICATION mode, as it runs in detached mode on YARN | ||
| if (deployMode != FlinkDeployMode.APPLICATION) { | ||
| args.add(FlinkConstants.FLINK_SHUTDOWN_ON_ATTACHED_EXIT); // -sae | ||
| } |
Member
There was a problem hiding this comment.
We should make it configurable in UI and set it as off by default.
SbloodyS
changed the title
SbloodyS
added
first time contributor
SbloodyS
changed the title
SbloodyS
changed the title
Author
|
Hi @SbloodyS , thank you for the review feedback! I understand the requirement to make the Current SituationThe current PR removes if (deployMode != FlinkDeployMode.APPLICATION) {
args.add(FlinkConstants.FLINK_SHUTDOWN_ON_ATTACHED_EXIT);
}Proposed SolutionI'''d like to propose adding a UI-configurable option for the Implementation Plan
Benefits
QuestionsBefore proceeding with implementation, I'''d like to confirm:
Looking forward to your feedback! Thanks! |
Member
|
@chris-fast Excellent. Your description is very accurate and correct. Please modify this PR according to your description. |
…h default off Changes: - Add shutdownOnAttachedExit field to FlinkParameters with enhanced JavaDoc - Change logic from hardcoded deployMode check to configuration-based - Add UI switch control in Flink task form (positioned after Yarn Queue) - Add comprehensive test cases for all scenarios (null, false, true, APPLICATION mode) - Add Chinese and English i18n translations - Default value: false (disabled for safety and backward compatibility) This addresses the reviewer's feedback to make the -sae parameter configurable via UI instead of hardcoded behavior based on deploy mode. The implementation uses Boolean type (three-state: null/false/true) to ensure backward compatibility with existing tasks.
chris-fast
changed the title
Author
|
@SbloodyS I've updated the PR according to the plan, PTAL. Thanks! |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fixes #17908
The
-sae(--shutdownOnAttachedExit) parameter was causing Flink tasks in YARN Application mode to terminate unexpectedly. Based on reviewer feedback, this parameter is now configurable via the UI instead of being hardcoded based on deploy mode.Root Cause
Previously, the
-saeparameter was automatically added for all non-APPLICATION modes. This hardcoded behavior didn't provide users with the flexibility to control this parameter based on their specific use cases.Solution
Made the
-saeparameter fully configurable through the UI:shutdownOnAttachedExitfield toFlinkParametersBrief changelog
shutdownOnAttachedExitfield toFlinkParameterswith enhanced JavaDocFlinkArgsUtils.buildRunCommandLine()to use configuration-based logicVerifying this change
Test Cases Coverage
New test cases added:
testRunJarWithShutdownOnAttachedExitEnabled()- Explicitly enabled (true)testRunJarWithShutdownOnAttachedExitDisabled()- Explicitly disabled (false)testRunJarWithShutdownOnAttachedExitInApplicationMode()- APPLICATION mode with enabledExisting tests updated:
-saeparameterBehavior Matrix
-saeAdded?Backward Compatibility
✅ Fully backward compatible:
Booleantype (three-state: null/false/true)nullvalue represents existing tasks (no -sae parameter)falsevalue represents explicitly disabledtruevalue represents explicitly enabledUI Changes
A new switch control "Shutdown On Attached Exit" has been added to the Flink task configuration form:
-saeparameter to Flink commandRelated issues
Fixes #17908