Skip to content

[Fix-17912] Fix http plugin cannot send json nested types #17911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ruanwenjun merged 4 commits into from
Jan 29, 2026
+8 −4
Merged

[Fix-17912] Fix http plugin cannot send json nested types #17911

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
596df7c
fix Modify HttpSender.bodyParams generic type to Map<String, Object>
Jan 27, 2026
95b1863
run mvn spotless:apply to format the code
Jan 28, 2026
6608c63
[Fix-17912] Fix add import of TypeReference
Jan 28, 2026
e872f51
[Fix-17912] Modification method: org.apache.dolphinscheduler.plugin.a…
Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions ...er-alert-http/src/main/java/org/apache/dolphinscheduler/plugin/alert/http/HttpSender.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,14 @@
import lombok.SneakyThrows;
import lombok.extern.slf4j.Slf4j;

import com.fasterxml.jackson.core.type.TypeReference;

@Slf4j
public final class HttpSender {

private Map<String, String> headerParams;
private OkHttpRequestHeaderContentType contentType;
private Map<String, String> bodyParams;
private Map<String, Object> bodyParams;
private HttpRequestMethod requestType;
private int timeout;
private String url;
Expand All @@ -69,7 +71,8 @@ private void paramsValidator(Map<String, String> paramsMap) {

String bodyParamsString = paramsMap.get(HttpAlertConstants.NAME_BODY_PARAMS);
if (StringUtils.isNotBlank(bodyParamsString)) {
bodyParams = JSONUtils.toMap(bodyParamsString);
bodyParams = JSONUtils.parseObject(bodyParamsString, new TypeReference<Map<String, Object>>() {
});
if (bodyParams == null) {
throw new IllegalArgumentException("bodyParams is not a valid json");
}
Expand Down Expand Up @@ -215,8 +218,9 @@ private void setMsgInRequestBody(String msg) {
}

bodyParams.forEach((key, value) -> {
if (value.contains(HttpAlertConstants.MSG_PARAMS)) {
bodyParams.put(key, value.replace(HttpAlertConstants.MSG_PARAMS, msg));
String valueOf = String.valueOf(value);
if (valueOf.contains(HttpAlertConstants.MSG_PARAMS)) {
bodyParams.put(key, valueOf.replace(HttpAlertConstants.MSG_PARAMS, msg));
}
});
}
Expand Down
Loading