Skip to content

Conversation

@maomao199691
Copy link
Contributor

@maomao199691 maomao199691 commented Jan 30, 2026

Purpose of the pull request

Handling http alarm timeout exception

fix #17915

Brief change log

Fixed the error in the timeout unit in the HTTP alert plugin

Verify this pull request

This change added tests and can be verified as follows:

  • Manually verified the change by testing locally. -->

Before repair:

Snipaste_2026-01-27_19-02-08 Snipaste_2026-01-27_19-04-12

After repair:
Snipaste_2026-01-27_19-06-45

maomaolong and others added 2 commits January 30, 2026 14:03
… HTTP alert plugin, where the unit in the code is not consistent with the page.
@SbloodyS SbloodyS added bug Something isn't working first time contributor First-time contributor labels Jan 30, 2026
@SbloodyS SbloodyS added this to the 3.4.1 milestone Jan 30, 2026
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2026

@SbloodyS SbloodyS merged commit 62d0b04 into apache:dev Feb 2, 2026
93 of 99 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 2, 2026

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend bug Something isn't working first time contributor First-time contributor ready-to-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][Alert] The alarm timeout time unit for the HTTP plugin is incorrect

3 participants