-
Notifications
You must be signed in to change notification settings - Fork 5k
[Improvement-17564][Helm] Update MinIO Helm chart version #17955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
[Improvement-17564][Helm] Update MinIO Helm chart version #17955
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request claims to update the MinIO Helm chart version from 11.10.13 to 11.10.26 as part of a larger effort to update Bitnami Helm chart dependencies. However, the PR contains extensive unrelated Java code changes that refactor the workflow execution graph assembly to use a deferred initialization pattern.
Changes:
- MinIO Helm chart version updated from 11.10.13 to 11.10.26 in Chart.yaml
- Complete refactoring of workflow execution graph initialization to use deferred assembly pattern with IWorkflowExecutionGraphAssembler
- Multiple command handlers modified to create assembler lambdas instead of eagerly building execution graphs
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| deploy/kubernetes/dolphinscheduler/Chart.yaml | Updates MinIO dependency version from 11.10.13 to 11.10.26 |
| dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteContext.java | Adds deferred initialization support for workflow execution graph with volatile field and double-checked locking |
| dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/IWorkflowExecuteContext.java | Adds interface methods for initializing and checking workflow execution graph state |
| dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/workflow/statemachine/WorkflowRunningStateAction.java | Adds initialization logic with error handling during workflow start event |
| dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/graph/IWorkflowExecutionGraphAssembler.java | New functional interface for deferred workflow execution graph assembly |
| dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/command/handler/WorkflowFailoverCommandHandler.java | Refactors to create assembler lambda instead of eagerly building execution graph |
| dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/command/handler/RunWorkflowCommandHandler.java | Refactors to create assembler lambda instead of eagerly building execution graph |
| dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/command/handler/RecoverSerialWaitCommandHandler.java | Returns null assembler for serial wait recovery case |
| dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/command/handler/RecoverFailureTaskCommandHandler.java | Refactors to create assembler lambda instead of eagerly building execution graph |
| dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/command/handler/ReRunWorkflowCommandHandler.java | Wraps parent assembler to mark task instances as invalid before graph assembly |
| dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/command/handler/AbstractCommandHandler.java | Changes method signature from assembleWorkflowExecutionGraph to createWorkflowExecutionGraphAssembler |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.../dolphinscheduler/server/master/engine/command/handler/RecoverFailureTaskCommandHandler.java
Outdated
Show resolved
Hide resolved
.../apache/dolphinscheduler/server/master/engine/command/handler/RunWorkflowCommandHandler.java
Outdated
Show resolved
Hide resolved
...he/dolphinscheduler/server/master/engine/command/handler/WorkflowFailoverCommandHandler.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteContext.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteContext.java
Fixed
Show fixed
Hide fixed
|
@Gallardot Could you please add the improvement label and set a milestone for this PR? |
| /** | ||
| * Assemble the workflow execution graph assembler. | ||
| * <p> | ||
| * The assembler is used to defer the initialization of the WorkflowExecutionGraph | ||
| * until the WorkflowStartLifecycleEvent is fired. This reduces transaction time | ||
| * during command processing. | ||
| */ | ||
| protected void assembleWorkflowExecutionGraphAssembler( | ||
| final WorkflowExecuteContextBuilder workflowExecuteContextBuilder) { | ||
| final IWorkflowExecutionGraphAssembler assembler = createWorkflowExecutionGraphAssembler( | ||
| workflowExecuteContextBuilder); | ||
| workflowExecuteContextBuilder.setWorkflowExecutionGraphAssembler(assembler); | ||
| } | ||
|
|
||
| /** | ||
| * Create the workflow execution graph assembler. | ||
| * <p> | ||
| * Subclasses should implement this method to provide the logic for building | ||
| * the WorkflowExecutionGraph. The returned assembler will be invoked when | ||
| * the WorkflowStartLifecycleEvent is fired. | ||
| * | ||
| * @return the assembler for creating the WorkflowExecutionGraph, or null if no graph is needed | ||
| */ | ||
| protected abstract IWorkflowExecutionGraphAssembler createWorkflowExecutionGraphAssembler( | ||
| final WorkflowExecuteContextBuilder workflowExecuteContextBuilder); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please avoid all this unnessnary changes.
3eddb30 to
2ca7b65
Compare
This PR updates the MinIO Helm chart version to align with newer Bitnami Helm
charts and ensure compatibility with recent Helm updates.
Part of #17560.
Resolves #17564.