[Improvement-18064][ApiServer] Update globalParams replace logic and test case#18068
Open
njnu-seafish wants to merge 4 commits intoapache:devfrom
Open
[Improvement-18064][ApiServer] Update globalParams replace logic and test case#18068njnu-seafish wants to merge 4 commits intoapache:devfrom
njnu-seafish wants to merge 4 commits intoapache:devfrom
Conversation
SbloodyS
changed the title
SbloodyS
changed the title
|
ruanwenjun
reviewed
Mar 13, 2026
Member
ruanwenjun
left a comment
ruanwenjun
left a comment
There was a problem hiding this comment.
It's better to use a utils to do this, the calculate logic also exist in master.
I think we should use a table to store some of the runtime context of workflow instances, such as parameters.(This can be a final solution)
Contributor
Author
Sure, I'll wait until the other PRs are merged before fixing this one to avoid conflicts. |
added 2 commits
March 18, 2026 11:53
# Conflicts: # dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/WorkflowInstanceServiceImpl.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was this PR generated or assisted by AI?
NO
Purpose of the pull request
close #18064
Brief change log
Update globalParams replace logic and test case
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md