Skip to content

Conversation

@tinnou
Copy link
Contributor

@tinnou tinnou commented Sep 30, 2025

Description

Add support in the web console for providing arrays (i.e ARRAY type) dynamic parameters in the workbench -> parameters dialog view when executing SQL queries.

This PR depends on druid-query-toolkit/pull/105 which makes the QueryParameter.value property support arrays.

Screen.Recording.-.480p.mov

Release note

New: You can now define ARRAY type parameters in the query console.


Key changed/added classes in this PR
  • query-parameters-dialog.tsx

This PR has:

  • a release note entry in the PR description.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • been tested in a test Druid cluster.

@vogievetsky
Copy link
Contributor

You want to run script/licenses and check in the changes that script makes also. Looks good otherwise

@vogievetsky
Copy link
Contributor

From the failing test:

[INFO] Checking formatting...
[INFO] [warn] src/views/workbench-view/query-parameters-dialog/query-parameters-dialog.tsx
[INFO] [warn] Code style issues found in the above file. Forgot to run Prettier?

Fix this by running npm run prettify

@vogievetsky
Copy link
Contributor

I think you need to update the snapshots. Try npm run jest -- -u and check in the changes if they look right

@tinnou
Copy link
Contributor Author

tinnou commented Oct 27, 2025

I think you need to update the snapshots. Try npm run jest -- -u and check in the changes if they look right

I believe I did in the previous commit named update test snapshot

@tinnou
Copy link
Contributor Author

tinnou commented Oct 28, 2025

Looks like the unit tests fail for a reason unrelated to the PR, do you think a rebase/merge with main is necessary here @vogievetsky

@vogievetsky vogievetsky merged commit 3f2ba2f into apache:master Oct 29, 2025
91 of 92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants