-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement dubboctl dashboard subcmd #1197
Implement dubboctl dashboard subcmd #1197
Conversation
…into refactor-with-go
…into refactor-with-go
…into refactor-with-go
…into refactor-with-go
…into refactor-with-go
…into refactor-with-go
Codecov Report
@@ Coverage Diff @@
## refactor-with-go #1197 +/- ##
====================================================
- Coverage 49.47% 48.74% -0.73%
====================================================
Files 95 97 +2
Lines 5114 5217 +103
Branches 41 41
====================================================
+ Hits 2530 2543 +13
- Misses 2325 2415 +90
Partials 259 259
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What is the purpose of the change
For simplifying port-forward operation and opening component dashboard in browser directly, implement dashboard subcommand.
eg: dubboctl dashboard grafana
It would create k8s PortForwarder and listen on localhost:3000 automatically. Then it opens grafana dashboard in browser.
Now it supports Admin, Grafana, Nacos, Prometheus, Skywalking, Zipkin.(Zookeeper doesn't have embedded dashboard)
Brief changelog
See /pkg/dubboctl/cmd/subcmd/dashboard_all_cmds. I do not create individual file for every component such as dashboard_grafana cause processing logic for every component is similar. So I aggregate all subcmds about dashboard.
Verifying this change
dubboctl manifest install
dubboctl dashboard grafana