[fix simple refactor] Differentiate between kubuclient and certclient #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjmshsh
changed the title
sjmshsh
changed the title
Codecov Report
@@ Coverage Diff @@
## refactor-with-go-components-experimental #1205 +/- ##
============================================================================
+ Coverage 48.99% 49.21% +0.21%
============================================================================
Files 113 113
Lines 6043 6010 -33
Branches 41 41
============================================================================
- Hits 2961 2958 -3
+ Misses 2827 2797 -30
Partials 255 255
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
chickenlj
reviewed
Jul 19, 2023
pkg/core/kubuclient/client/kubu.go
Outdated
| "k8s.io/client-go/util/homedir" | ||
| ) | ||
|
|
||
| type KubuClient interface { |
There was a problem hiding this comment.
Typo? Should it be KubeClient?
|
Kudos, SonarCloud Quality Gate passed!
|
chickenlj
merged commit d292375
into
apache:refactor-with-go-components-experimental
4 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The concepts of kubeclient and certclient were a bit confusing before. This PR mainly separates them.