-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix simple refactor] Differentiate between kubuclient and certclient #1205
[fix simple refactor] Differentiate between kubuclient and certclient #1205
Conversation
Codecov Report
@@ Coverage Diff @@
## refactor-with-go-components-experimental #1205 +/- ##
============================================================================
+ Coverage 48.99% 49.21% +0.21%
============================================================================
Files 113 113
Lines 6043 6010 -33
Branches 41 41
============================================================================
- Hits 2961 2958 -3
+ Misses 2827 2797 -30
Partials 255 255
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pkg/core/kubuclient/client/kubu.go
Outdated
"k8s.io/client-go/util/homedir" | ||
) | ||
|
||
type KubuClient interface { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo? Should it be KubeClient
?
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
d292375
into
apache:refactor-with-go-components-experimental
The concepts of kubeclient and certclient were a bit confusing before. This PR mainly separates them.