Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated cypress files for version 12.17.3 #380

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Updated cypress files for version 12.17.3 #380

merged 3 commits into from
Aug 29, 2023

Conversation

Jyyjy
Copy link
Contributor

@Jyyjy Jyyjy commented Aug 9, 2023

I followed the cypress migration wizard to resolve some compatibility issues with the new version.

#379

@Jyyjy Jyyjy marked this pull request as draft August 9, 2023 18:43
@poorejc
Copy link
Contributor

poorejc commented Aug 10, 2023

It looks like unit tests aren't passing on Test. It looks like there's a flag in a "support file" that's not properly configured:

Your project does not contain a default supportFile. We expect a file matching cypress/support/e2e.{js,jsx,ts,tsx} to exist.

If a support file is not necessary for your project, set supportFile to false.

from: https://github.com/apache/flagon-useralejs/actions/runs/5813252179/job/15760397989?pr=380#step:5:210

Are the tests running successfully for you, locally?

@Jyyjy
Copy link
Contributor Author

Jyyjy commented Aug 10, 2023

It looks like unit tests aren't passing on Test. It looks like there's a flag in a "support file" that's not properly configured:

Your project does not contain a default supportFile. We expect a file matching cypress/support/e2e.{js,jsx,ts,tsx} to exist.

If a support file is not necessary for your project, set supportFile to false.

from: https://github.com/apache/flagon-useralejs/actions/runs/5813252179/job/15760397989?pr=380#step:5:210

Are the tests running successfully for you, locally?

Yes the tests were passing for me locally because cypress used to auto-generate some files that it no longer does. These files are ignored in .gitignore, so they were leftover on my machine and not in this repo.

I thought the issue was that GitHub was complaining about not having a GPU, while my local machine was not. This error is still in the GitHub actions logs, and was probably already there, but it is not fatal.
[2276:0810/155247.699260:ERROR:gpu_memory_buffer_support_x11.cc(44)] dri3 extension not supported.

@Jyyjy Jyyjy marked this pull request as ready for review August 10, 2023 16:00
@Jyyjy Jyyjy merged commit 67fece6 into apache:test Aug 29, 2023
2 checks passed
@Jyyjy Jyyjy deleted the cypress branch August 29, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants