Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug 'AuthHeaders ignored for sendOnClose' #452

Closed
wants to merge 3 commits into from

Conversation

rc10house
Copy link
Contributor

Function sendOnClose() no longer uses global.navigator.sendBeacon() to send its logs, now uses global.fetch() which supports authentication headers.

@rc10house
Copy link
Contributor Author

Added pre-commit hooks for linting, formatting, building, and testing. Note: this commit ran the formatter resulting in a large number of source files being modified (formatted). The important changed files in commit 1512c48 are .husky/pre-commit, package.json, eslint.config.mjs, .eslintrc.json

@EandrewJones
Copy link
Contributor

@rc10house I just noticed a few things.

  1. You're doing this work directly on your master and merging to master.
  2. You've combined multiple tickets into a single PR.

Please do the following:

  1. Revoke this PR.
  2. Create a new branch for each issue you are working on and include the issue number in the branch title, e.g. 399-auth-headers-ignored-send-on-close
  3. Cherry pick the correct commits from your master into each branch, respectively.
  4. Roll back your master to match the REMOTE master
  5. Squash the commits for each issue-branch into a single commit.
  6. Create separate PRs for each of the issue-branches, and reference the issues in the PR text via #<issue-number-here>.

This will keep the history clean and maintain a one-one mapping between commits and issues. Very important.

@rc10house
Copy link
Contributor Author

Will do. Sorry, I had issue/feature branches locally but merged them into master before opening the PR.

@rc10house rc10house closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants