-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added websockets for sending logs if available #489
Conversation
Had to separate some tests to avoid websockets being ran from within |
You can add another webserver to test/e2e/playwright.config.ts and specify which webserver to use for different projects. Set existing projects to use the existing webserver, and create a new project with a websocket server. I would set http and websockets to different ports within the same server and specify "reuseExistingServer: True" Relevant docs: |
@rc10house Bumping this. Would be nice to get this over the finish line if you have time. |
30f5dfb
to
7da6d17
Compare
7da6d17
to
7f710a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good test coverage, thanks for being persistent. For my own understanding, what's the difference between jest specs that have "@jest-environment jsdom" and those that don't?
@Jyyjy for some reason, the previous jest-environment specification (in |
@Jyyjy the specific tests with the added |
@EandrewJones gonna leave this up for a couple days in case you want to review, if not I'll merge. |
Go ahead and merge. I'm unlikely to find the time to give this an in-depth
look in the next few days.
Best
Evan Jones
Website: www.ea-jones.com
…On Wed, Oct 16, 2024 at 12:11 PM Jason Young ***@***.***> wrote:
@EandrewJones <https://github.com/EandrewJones> gonna leave this up for a
couple days in case you want to review, if not I'll merge.
—
Reply to this email directly, view it on GitHub
<#489 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJ2T6ALM22IGBIC63TYZPPDZ3226NAVCNFSM6AAAAABMYNXDD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJXG4ZTCMBRGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Adds functionality to
main.ts
to check if the providedconfig.url
is running a WebSocket server. If so, we upgrade the connection to send data over WebSockets and use this for sending all logs. If not, we send data with the existing REST functionality. I also added a test/example WebSockets serverexamples/ws-server.js
.Note: WebSockets will not run when using Jest to test currently, so the application skips attempting to create a WebSockets connection if it detects running in a test environment (headless browser).
Closes: #444