-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-35981][transform] Transform rule support referencing one column more than once #3515
Conversation
please help to review this PR, thanks. @yuxiqian |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just left a minor comment about test case.
...rc/test/java/org/apache/flink/cdc/runtime/operators/transform/TransformDataOperatorTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! To make CI pass, please wait for #3516 to be merged, and rebase this PR to master
then.
# Conflicts: # flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/transform/ProjectionColumnProcessor.java # flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/transform/TransformFilterProcessor.java # flink-cdc-runtime/src/test/java/org/apache/flink/cdc/runtime/operators/transform/PostTransformOperatorTest.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MOBIN-F for the contribution, LGTM
…more than once This closes apache#3515.
Currently, transform rule (projection / filtering) doesn't support referencing one column more than once, which means if we write such a projection rule:
transform:
projection: *, age * age AS age_square
filter: age < 18 OR age > 60