[FLINK-35067][cdc-connector][postgres] Adding metadata 'row_kind' for Postgres CDC Connector. #3716
+70
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Postgres CDC Connector.
|
Hi @oli2v, This feature is meaningful to me, but it seems that there are many irrelevant changes in the code (including test code), was this adjusted by IDE？We should try to minimize irrelevant changes as much as possible. |
…ind' for Postgres CDC Connector." This reverts commit 028313a.
|
Hi @lvyanquan, those irrelevant changes in the code were indeed due to the IDE. I just pushed a new commit trying to minimize them. |
lvyanquan
reviewed
Nov 12, 2024
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.Assert.assertTrue; | ||
| import static org.junit.Assert.fail; | ||
|
|
There was a problem hiding this comment.
Thanks for the update and it looks better, but I'm wondering this change of import orders is necessary?
There was a problem hiding this comment.
Thanks for the update and it looks better, but I'm wondering this change of import orders is necessary?
You can use mvn spotless:apply to correct the import orders.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.