[FLINK-36817] Introduce KafkaConsumerFactory #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) |
lkokhreidze
changed the title
|
Will add the javadocs. But first wanted to get the initial feedback if this makes sense. |
lkokhreidze
commented
Nov 28, 2024
| import java.util.Properties; | ||
|
|
||
| public interface KafkaConsumerFactory { | ||
| KafkaConsumer<byte[], byte[]> get(Properties properties); |
There was a problem hiding this comment.
I was debating myself if it would be better to return Consumer interface instead of the implementation. Happy to change it if community agrees that returning an interface is the better choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain scenarios users of the
KafkaSourcein the flink-connector-kafka might want to provide their own KafkaConsumer. Right now this is not possible as consumer is created in the KafkaPartitionSplitReader which makes customisation impossible.Proposal is to let users pass
KafkaConsumerFactorywhen building the KafkaSource.Builder will have a default implementation which creates the KafkaConsumer the same as it is done now.