Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-35038] Bump org.yaml:snakeyaml to 2.2 #93

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

uce
Copy link
Contributor

@uce uce commented Apr 10, 2024

SnakeYAML introduced breaking API changes and behavior changes between 1.31 and 2.2. This PR uses the updated APIs and explicitly allows the global tag for StreamMetadata (see changed SnakeYAML behavior in snakeyaml/snakeyaml@2b8d47c).

Notes

  • This dependency is only used in tests, so therefore not critical to address.
  • Some tests are currently broken. Everything should be green once [FLINK-35007] Add support for Flink 1.19 #90 goes in and this PR is rebased. I verified the change locally.

Closes #85.

Copy link

boring-cyborg bot commented Apr 10, 2024

Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)

dependabot bot and others added 3 commits April 11, 2024 10:28
Bumps [org.yaml:snakeyaml](https://bitbucket.org/snakeyaml/snakeyaml) from 1.31 to 2.0.
- [Commits](https://bitbucket.org/snakeyaml/snakeyaml/branches/compare/snakeyaml-2.0..snakeyaml-1.31)

---
updated-dependencies:
- dependency-name: org.yaml:snakeyaml
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
SnakeYAML introduced breaking API changes and behavior changes between 1.31 and
2.2. This commit uses the updated APIs and explicitly allows the global tag
for StreamMetadata (see changed SnakeYAML behavior in [1]).

[1] snakeyaml/snakeyaml@2b8d47c
@uce uce force-pushed the flink-35038-snakeyaml branch from 76601ef to 378a121 Compare April 11, 2024 08:28
@uce
Copy link
Contributor Author

uce commented Apr 11, 2024

I rebased on main after #90 has been merged to get a green build.

Builds are green now. Note that the first run failed with an error (for reference: https://github.com/apache/flink-connector-kafka/actions/runs/8643772979/job/23697488112).

@MartijnVisser Can you take a look at this PR?

Copy link
Contributor

@MartijnVisser MartijnVisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MartijnVisser MartijnVisser merged commit 369e7be into apache:main Apr 11, 2024
13 checks passed
Copy link

boring-cyborg bot commented Apr 11, 2024

Awesome work, congrats on your first merged pull request!

MartijnVisser pushed a commit that referenced this pull request Apr 11, 2024
* Bump org.yaml:snakeyaml from 1.31 to 2.0 in /flink-connector-kafka

Bumps [org.yaml:snakeyaml](https://bitbucket.org/snakeyaml/snakeyaml) from 1.31 to 2.0.
- [Commits](https://bitbucket.org/snakeyaml/snakeyaml/branches/compare/snakeyaml-2.0..snakeyaml-1.31)

---
updated-dependencies:
- dependency-name: org.yaml:snakeyaml
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

* [FLINK-XXXXX] Bump org.yaml:snakeyaml from 2.0 to 2.2

* [FLINK-35038] Fix SnakeYAML usage after version bump

SnakeYAML introduced breaking API changes and behavior changes between 1.31 and
2.2. This commit uses the updated APIs and explicitly allows the global tag
for StreamMetadata (see changed SnakeYAML behavior in [1]).

[1] snakeyaml/snakeyaml@2b8d47c

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Martijn Visser <2989614+MartijnVisser@users.noreply.github.com>
(cherry picked from commit 369e7be)
@uce uce deleted the flink-35038-snakeyaml branch April 11, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants