Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-35007][BP v3.1] Add support for Flink 1.19 (#90) #94

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

MartijnVisser
Copy link
Contributor

@MartijnVisser MartijnVisser commented Apr 11, 2024

Backport of #90

(cherry picked from commit 897001d)

* [FLINK-35007] Add support for Flink 1.19

This also includes dropping the weekly tests for the `v3.0` branch, since `v3.1` has been released and that's our main version going forward.

* [FLINK-35007] Remove unused test class that relied on removed Internal class

* [FLINK-35007][ci] Copy old `flink-conf.yaml` to make sure that all Python tests work for Flink 1.x releases

(cherry picked from commit 897001d)
}, {
flink: 1.19.0,
branch: v3.1,
jdk: '8, 11, 17',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
jdk: '8, 11, 17',
jdk: '8, 11, 17, 21',

shouldn't it be 21 as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically yes, but weeklys actually can't be run from non main branches, so will need to be fixed there.

@MartijnVisser MartijnVisser requested a review from snuyanzin April 11, 2024 10:30
Copy link
Contributor

@snuyanzin snuyanzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once ci is green

@MartijnVisser MartijnVisser merged commit 809cb07 into apache:v3.1 Apr 11, 2024
13 checks passed
@MartijnVisser MartijnVisser deleted the bp/flink-35007-119-support branch April 11, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants