Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-34020] Bump CI flink version on flink-connector-rabbitmq #22

Merged
merged 8 commits into from
Jan 12, 2024
Merged

[FLINK-34020] Bump CI flink version on flink-connector-rabbitmq #22

merged 8 commits into from
Jan 12, 2024

Conversation

MartijnVisser
Copy link
Contributor

No description provided.

@MartijnVisser MartijnVisser force-pushed the fixci branch 3 times, most recently from 37f412b to 5c5d953 Compare January 8, 2024 12:01
@MartijnVisser
Copy link
Contributor Author

@snuyanzin Any ideas why everything passes for the non 1.19-SNAPSHOT tests, but nothing for 1.19-SNAPSHOT?

@snuyanzin
Copy link
Contributor

The problem is with
org.apache.flink.streaming.connectors.rabbitmq.RMQSourceTest
especially with org.apache.flink.streaming.connectors.rabbitmq.RMQSourceTest#testDuplicateId which became endless...

if you comment it it will stop hanging however there are some tests which will fail...
Need to investigate what changes in 1.19 or in deps (e.g. result of converge deps fixes) leads to such behavior

@MartijnVisser
Copy link
Contributor Author

if you comment it it will stop hanging however there are some tests which will fail...

The weird thing is that it passes flawless locally. I can't get this reproduced locally

@snuyanzin
Copy link
Contributor

I was able to reproduce it locally with

mvn clean install -Dflink.version=1.19-SNAPSHOT

@snuyanzin
Copy link
Contributor

snuyanzin commented Jan 8, 2024 •
edited
Loading

local test shows that this is the first commit

commit e9353319ad625baa5b2c20fa709ab5b23f83c0f4 (HEAD)
Author: Wencong Liu <liuwenclever@163.com>
Date:   Fri Sep 8 11:04:56 2023 +0800

    [FLINK-32978][flink-core] Migrate the usage of RichFunction#open(Configuration parameters) to RichFunction#open(OpenContext openContext)
    
    This closes #23058

when it stopped workiing for flink connector rabbitmq
probably it is the reason

@snuyanzin
Copy link
Contributor

snuyanzin commented Jan 8, 2024 •
edited
Loading

I commented about that at FLINK-32978

also I submitted a PR MartijnVisser#1 to your branch applying WA to work after changes within FLINK-32978 and making it passing tests
https://github.com/snuyanzin/flink-connector-rabbitmq/actions/runs/7453993758

snuyanzin
snuyanzin approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@snuyanzin snuyanzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops these 2 lines are useless, we could remove them

LGTM

...nnector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSource.java Outdated Show resolved Hide resolved
...nnector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSource.java Outdated Show resolved Hide resolved
MartijnVisser and others added 2 commits January 12, 2024 08:45
@MartijnVisser @snuyanzin
Update flink-connector-rabbitmq/src/main/java/org/apache/flink/stream…
b6d9b04 
…ing/connectors/rabbitmq/RMQSource.java

Co-authored-by: Sergey Nuyanzin <sergey.nuyanzin@aiven.io>
@MartijnVisser @snuyanzin
Update flink-connector-rabbitmq/src/main/java/org/apache/flink/stream…
fafedcb 
…ing/connectors/rabbitmq/RMQSource.java

Co-authored-by: Sergey Nuyanzin <sergey.nuyanzin@aiven.io>
@MartijnVisser MartijnVisser merged commit 33d125f into apache:main Jan 12, 2024
12 checks passed
@MartijnVisser MartijnVisser deleted the fixci branch January 12, 2024 08:35
@MartijnVisser MartijnVisser mentioned this pull request Jan 12, 2024
Closed
MartijnVisser added a commit to MartijnVisser/flink-connector-rabbitmq that referenced this pull request Jan 12, 2024
@MartijnVisser
[FLINK-34020] Bump CI flink version on flink-connector-rabbitmq. This c…
ed213f8 
…loses apache#22

* [FLINK-34020] Bump CI flink version on flink-connector-rabbitmq

* [hotfix] Set lowest supported Flink version to 1.16.0 since that's still supported

* [hotfix] Set copyright year to 2024

---------

Co-authored-by: Hang Ruan <ruanhang1993@hotmail.com>
Co-authored-by: Sergey Nuyanzin <sergey.nuyanzin@aiven.io>

(cherry picked from commit 33d125f)
MartijnVisser added a commit to MartijnVisser/flink-connector-rabbitmq that referenced this pull request Jan 12, 2024
@MartijnVisser
[FLINK-34020] Bump CI flink version on flink-connector-rabbitmq. This c…
e30cb08 
…loses apache#22

* [FLINK-34020] Bump CI flink version on flink-connector-rabbitmq

* [hotfix] Set lowest supported Flink version to 1.16.0 since that's still supported

* [hotfix] Set copyright year to 2024

---------

Co-authored-by: Hang Ruan <ruanhang1993@hotmail.com>
Co-authored-by: Sergey Nuyanzin <sergey.nuyanzin@aiven.io>

(cherry picked from commit 33d125f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snuyanzin snuyanzin snuyanzin approved these changes

Assignees
No one assigned
Labels
component=BuildSystem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MartijnVisser @snuyanzin