Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-37126] Add Validator for Autoscaler #936

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

huyuanfeng2018
Copy link
Contributor

What is the purpose of the change

Add Validator for Autoscler, Facilitates StandaloneAutoscaler to detect configuration anomalies in advance

Brief change log

  • Migrate the verification part of Autoscaler in DefaultAutoscalerValidator to the Autoscaler module
  • Verify the Autoscaler config separately in StandaloneAutoscaler. If there are illegal parameters, report them through events.

Verifying this change

This change added tests and can be verified as follows:

  • add StandaloneAutoscalerValidatorTest Used to verify parameter verification under standloneAutoscaler
  • The old test cases cover the test for Autoscaler parameter verification under the operator

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API, i.e., is any changes to the CustomResourceDescriptors: (no)
  • Core observer or reconciler logic that is regularly executed: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)

@huyuanfeng2018 huyuanfeng2018 force-pushed the FLINK-37126 branch 2 times, most recently from 92a1be4 to 15982fd Compare January 20, 2025 07:29
@huyuanfeng2018 huyuanfeng2018 marked this pull request as draft January 20, 2025 07:29
@huyuanfeng2018 huyuanfeng2018 force-pushed the FLINK-37126 branch 2 times, most recently from 439229b to 85675ee Compare January 20, 2025 08:15
@huyuanfeng2018 huyuanfeng2018 force-pushed the FLINK-37126 branch 2 times, most recently from 81de787 to 24edc0d Compare February 6, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant