Skip to content

Conversation

@JinwooHwang
Copy link
Contributor

Now that support/2.0 has been created, develop advances.

For all changes, please confirm:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
  • Has your PR been rebased against the latest commit within the target branch (typically develop)?
  • Is your initial contribution a single, squashed commit?
  • Does gradlew build run cleanly?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Now that support/2.0 has been created, develop advances.
@JinwooHwang
Copy link
Contributor Author

All checks have passed. We are ready to merge.

@JinwooHwang
Copy link
Contributor Author

Please let me know if you have any questions. Thank you for your help.

@leonfin
Copy link
Contributor

leonfin commented Dec 5, 2025

@JinwooHwang reviewed with AI. I can't approve so not sure it matters

Whitespace Pollution in Test Files

Location: All expected-pom.xml files (30 files modified)

Issue: The commit adds excessive trailing whitespace to every line in the expected POM files. This appears to be
an XML formatting change that:

  • Adds 3,248 insertions primarily consisting of whitespace
  • Makes diffs harder to read
  • Pollutes git history
  • Has no functional benefit

Example:

+
<!--

Each XML element now has trailing whitespace after the closing >, making the files unnecessarily larger.

otherwise looks fine

The roll to 2.1.0 commit (8e326d9) inadvertently added blank lines
with trailing whitespace throughout all expected-pom.xml test files.
This commit reverts those files to their clean state.

- 25 files affected
- Removed 3,230 lines of whitespace pollution
- No functional changes to actual POM content
@JinwooHwang
Copy link
Contributor Author

Hi @leonfin. Thank you so much for the thorough review and catching that whitespace pollution.

You're absolutely right - the roll commit inadvertently added ~3,230 lines of trailing whitespaces throughout all the expected-pom.xml files. I've addressed this in commit 387fe5f:

What was fixed:

  • Restored all 25 expected-pom.xml files to their clean state (before the roll)
  • Removed 3,230 lines of whitespace pollution
  • No functional changes to actual POM content

The files now have the proper formatting without the extraneous whitespaces. Really appreciate you taking the time to review this.

@JinwooHwang
Copy link
Contributor Author

@leonfin , @sboorlagadda , @raboof and @niallkp, all checks have passed. We are ready to merge. Please let me know if you have any concerns. Thank you for your continued support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants