Skip to content

[GOBBLIN-2202] Change aggregation temporality to DELTA instead of CUMULATIVE for Open Telemetry Metrics #4111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2025

Conversation

Blazer-007
Copy link
Member

@Blazer-007 Blazer-007 commented Apr 16, 2025

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    Changed Aggregation Temporality to DELTA instead of CUMULATIVE for Open Telemetry Metrics

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    NA

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@Blazer-007 Blazer-007 changed the title [GOBBLIN-XXX] Change aggregation temporality to DELTA instead of CUMULATIVE for Open Telemetry Metrics [GOBBLIN-2202] Change aggregation temporality to DELTA instead of CUMULATIVE for Open Telemetry Metrics Apr 16, 2025
@abhishekmjain
Copy link
Contributor

Will this impact consumers of the metrics working with CUMULATIVE?

@Blazer-007
Copy link
Member Author

Will this impact consumers of the metrics working with CUMULATIVE?

Yes this will impact the users who are working with OTel collector which supports only Cumulative .
Microsoft MDM doesn't support Cumulative specially for monotonic metrics that's why the change is required

@Blazer-007
Copy link
Member Author

@vsinghal85
Copy link
Contributor

Do we know why metrics were not being emitted using CUMULATIVE? In case if for some usecase we want to use CUMULATIVE, would that be something possible, or is there some blocker which prevents that?

@Blazer-007 Blazer-007 merged commit 0548766 into apache:master Apr 21, 2025
6 checks passed
@Blazer-007 Blazer-007 deleted the otel_metrics_fix branch April 21, 2025 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants