Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GUACAMOLE-1872: Show the recording playback controls when the mouse is moved. #922

Merged
merged 1 commit into from
Oct 24, 2023
Merged

GUACAMOLE-1872: Show the recording playback controls when the mouse is moved. #922

merged 1 commit into from
Oct 24, 2023

Conversation

jmuehlner
Copy link
Contributor

No description provided.

@jmuehlner jmuehlner force-pushed the GUACAMOLE-1872-show-recording-playback-controls-when-mouse-moved branch 4 times, most recently from d43a3ed to c7c7c5a Compare October 23, 2023 22:17
@jmuehlner jmuehlner force-pushed the GUACAMOLE-1872-show-recording-playback-controls-when-mouse-moved branch from c7c7c5a to 3a5d897 Compare October 24, 2023 16:13
mike-jumper
mike-jumper requested changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@mike-jumper mike-jumper left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need some @types. Otherwise, LGTM (assuming debounce() is indeed necessary).

guacamole/src/main/frontend/src/app/player/directives/player.js Outdated Show resolved Hide resolved
guacamole/src/main/frontend/src/app/player/directives/player.js Outdated Show resolved Hide resolved
guacamole/src/main/frontend/src/app/player/directives/player.js Show resolved Hide resolved
@jmuehlner jmuehlner force-pushed the GUACAMOLE-1872-show-recording-playback-controls-when-mouse-moved branch from 3a5d897 to 95b0b43 Compare October 24, 2023 18:42
@mike-jumper
Copy link
Contributor

@jmuehlner Think this should be against staging/1.5.4?

@jmuehlner
Copy link
Contributor Author

@jmuehlner Think this should be against staging/1.5.4?
Suuuure - it's not quite a bug exactly but I think it makes sense to include. I'll rebase.

@jmuehlner jmuehlner force-pushed the GUACAMOLE-1872-show-recording-playback-controls-when-mouse-moved branch from 95b0b43 to e5dcaa7 Compare October 24, 2023 22:14
@jmuehlner jmuehlner changed the base branch from master to staging/1.5.4 October 24, 2023 22:15
@jmuehlner jmuehlner force-pushed the GUACAMOLE-1872-show-recording-playback-controls-when-mouse-moved branch from e5dcaa7 to f6ed6d6 Compare October 24, 2023 22:17
@jmuehlner jmuehlner marked this pull request as draft October 24, 2023 22:31
@jmuehlner
Copy link
Contributor Author

This change doesn't quite work, due to a different bug that was fixed in master, in 2a2cef9. I'll need to port just the fix for the control bar hiding to 1.5.4 before this change is ready to go.

@jmuehlner
Copy link
Contributor Author

jmuehlner commented Oct 24, 2023 •
edited
Loading

depends on #923 ready to go!

@jmuehlner jmuehlner force-pushed the GUACAMOLE-1872-show-recording-playback-controls-when-mouse-moved branch from f6ed6d6 to 04c620f Compare October 24, 2023 23:53
@jmuehlner jmuehlner marked this pull request as ready for review October 24, 2023 23:54
@mike-jumper mike-jumper merged commit 57d3b1e into apache:staging/1.5.4 Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-jumper mike-jumper mike-jumper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmuehlner @mike-jumper