GUACAMOLE-1881: Add parameter token containing the domain of LDAP/AD usernames. #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom user credentials
…to derive static name.
mike-jumper
force-pushed
the
ldap-domain-token
branch
from
20e7033 to
c330dbb
Compare
josnabattula
approved these changes
May 16, 2024
necouchman
requested changes
May 16, 2024
...le-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java
Show resolved
Hide resolved
...le-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java
Outdated
Show resolved
Hide resolved
...le-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java
Show resolved
Hide resolved
|
@mike-jumper Can we get these changes into next release, its been months since I have raise pull request. |
|
@mike-jumper any plans to look into this pull request? it's been more than 6 months. |
|
@josnabattula Are you able to see Nick's comments above? |
I can see. But those comments are on your branch you have refactored after my commit cheery-picked. I am thinking you are going to resolve it. |
|
Oof, right - that was silly of me. Sorry about that, @josnabattula. |
… domain is used for a token.
mike-jumper
force-pushed
the
ldap-domain-token
branch
from
c330dbb to
37d8e5a
Compare
|
@necouchman Could you review again? All review comments are resolved now. thanks. |
necouchman
approved these changes
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is intended to supersede the changes proposed by poor @josnabattula via PR #931 that I have been very slow to review. It builds off the original commit (27bbd35) by:
TokenName.canonicalize()(there's no need to dynamically derive the token name of a static value).getDomainToken()renamed and redocumented asgetUserDomain()).Pattern(there's no need to repeatedly recompile the regex each time a user logs in - it never changes).