Merge 1.5.0 changes back to master.

apache · Nov 29, 2022 · add7ce3 · add7ce3
2 parents 5594182 + 7d16f67
commit add7ce3
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/src/libguac/client.c b/src/libguac/client.c
@@ -302,15 +302,15 @@ int guac_client_add_user(guac_client* client, guac_user* user, int argc, char**
         /* Update owner pointer if user is owner */
         if (user->owner)
             client->__owner = user;
-
-        /* Notify owner of user joining connection. */
-        else
-            guac_client_owner_notify_join(client, user);
 
     }
 
     pthread_rwlock_unlock(&(client->__users_lock));
 
+    /* Notify owner of user joining connection. */
+    if (retval == 0 && !user->owner)
+        guac_client_owner_notify_join(client, user);
+
     return retval;
 
 }
@@ -335,12 +335,12 @@ void guac_client_remove_user(guac_client* client, guac_user* user) {
     if (user->owner)
         client->__owner = NULL;
 
+    pthread_rwlock_unlock(&(client->__users_lock));
+
     /* Update owner of user having left the connection. */
-    else
+    if (!user->owner)
         guac_client_owner_notify_leave(client, user);
 
-    pthread_rwlock_unlock(&(client->__users_lock));
-
     /* Call handler, if defined */
     if (user->leave_handler)
         user->leave_handler(user);