Fix missing relocation for org.jspecify in hadoop-shaded-guava#50
Open
RomanVlasenko wants to merge 1 commit intoapache:trunkfrom
Open
Fix missing relocation for org.jspecify in hadoop-shaded-guava#50RomanVlasenko wants to merge 1 commit intoapache:trunkfrom
RomanVlasenko wants to merge 1 commit intoapache:trunkfrom
Conversation
org.jspecify:jspecify was added as a shaded artifact in 1.5.0 but without a corresponding relocation rule, causing its classes to be bundled at their original org/jspecify/annotations/ path. This produces classpath collisions in projects that also depend on the standalone org.jspecify:jspecify jar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
org.jspecify:jspecifywas added as a shaded artifact in 1.5.0 but without a corresponding relocation rule. As a result, its classes are bundled at their originalorg/jspecify/annotations/path inside thehadoop-shaded-guavajar.This causes classpath collisions in projects that also have a direct or transitive dependency on
org.jspecify:jspecify, since the same class files appear from two different jars.Fix
Add a
<relocation>rule fororg/jspecify/in themaven-shade-pluginconfiguration, consistent with howcom/google/andorg/checkerframework/are already handled.For code changes:
Use of AI
Yes — Claude (Anthropic) was used to help identify the root cause and draft this fix.