HBASE-29787 Run Yetus General Checks as a GitHub Action #7566

ndimiduk · 2025-12-19T11:17:46Z

No description provided.

ndimiduk · 2025-12-19T18:11:11Z

I think this is working. Please help me out by double-checking that the checks run by the new system have parity with the jenkins build.

Apache9 · 2025-12-20T09:06:57Z

I think this is working. Please help me out by double-checking that the checks run by the new system have parity with the jenkins build.

Let's just try it on a special branch? Scripts are always hard to review...

Apache9 · 2025-12-20T09:08:52Z

Ah, I saw the checks, let me check the result...

Apache9 · 2025-12-20T09:11:19Z

Seems we missed lots of checks...

+1 overall
Vote	Subsystem	Runtime	Log	Comment
Prechecks
+1	dupname	0m 0s		No case conflicting files found.
+1	@author	0m 0s		The patch does not contain any @author tags.
master Compile Tests
+1	spotless	0m 53s		branch has no errors when running spotless:check.
Patch Compile Tests
+1	codespell	0m 13s		No new issues.
+1	detsecrets	4m 22s		No new issues.
+1	blanks	0m 0s		The patch has no blanks issues.
+1	yamllint	0m 0s		No new issues.
+1	spotless	0m 35s		patch has no errors when running spotless:check.
Other Tests
+1	asflicense	0m 11s		The patch does not generate ASF License warnings.
6m 27s		
Subsystem	Report/Notes
GITHUB PR	https://github.com/apache/hbase/pull/7566
Optional Tests	dupname asflicense codespell detsecrets yamllint spotless
uname	Linux 5359e6d56b16 6.11.0-1018-azure #18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/github/workspace/src/dev-support/hbase-personality.sh
git revision	master / efb501962294022f359c4cba545386ca4c78c7e9
modules	C: . U: .
versions	git=2.34.1 maven=3.9.9 codespell=2.4.1 detsecrets=1.5.0 yamllint=1.35.1
Powered by	Apache Yetus 0.16.0-SNAPSHOT https://yetus.apache.org
This message was automatically generated.

.github/workflows/yetus-general-check.yml

we need to override these after the githubactions robot sets them so that they point to our nightlies upload path.

github-actions · 2026-01-12T13:38:28Z

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://nightlies.apache.org/hbase/HBase-PreCommit-GH-Actions-PR/PR-7566/44// in case of problems.

Apache-HBase · 2026-01-12T14:34:46Z

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7566/25/console in case of problems.

Apache-HBase · 2026-01-12T14:34:47Z

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7566/25/console in case of problems.

github-actions · 2026-01-12T14:40:58Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 17s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+0 🆗	yamllint	0m 0s		yamllint was not available.
-1 ❌	@author	0m 0s	/results-author.txt	The patch appears to contain 1 @author tags which the community has agreed to not allow in code contributions.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 22s		master passed
+1 💚	compile	9m 3s		master passed
+1 💚	checkstyle	1m 55s		master passed
+1 💚	spotbugs	8m 19s		master passed
+1 💚	spotless	0m 45s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 3s		the patch passed
+1 💚	compile	9m 5s		the patch passed
+1 💚	javac	9m 5s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 57s		the patch passed
-0 ⚠️	shellcheck	0m 1s	/results-shellcheck.txt	The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)
+1 💚	spotbugs	8m 27s		the patch passed
+1 💚	hadoopcheck	9m 4s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
-1 ❌	spotless	0m 7s		patch has 34 errors when running spotless:check, run spotless:apply to fix.
			_ Other Tests _
-1 ❌	asflicense	0m 20s	/results-asflicense.txt	The patch generated 1 ASF License warnings.
		62m 33s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://nightlies.apache.org/hbase/HBase-PreCommit-GH-Actions-PR/PR-7566/44/yetus-general-check/output/Dockerfile
GITHUB PR	#7566
Optional Tests	dupname asflicense codespell detsecrets shellcheck shelldocs spotless yamllint javac spotbugs checkstyle compile hadoopcheck hbaseanti
uname	Linux 85a853a792bd 6.11.0-1018-azure #18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `0d236cd`
Default Java	Eclipse Adoptium-17.0.11+9
spotless	https://nightlies.apache.org/hbase/HBase-PreCommit-GH-Actions-PR/PR-7566/44/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	161 (vs. ulimit of 30000)
modules	C: hbase-annotations . U: .
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 shellcheck=0.8.0
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2026-01-12T15:40:38Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 28s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+0 🆗	yamllint	0m 0s		yamllint was not available.
-1 ❌	@author	0m 0s	/results-author.txt	The patch appears to contain 1 @author tags which the community has agreed to not allow in code contributions.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 32s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 31s		master passed
+1 💚	compile	8m 37s		master passed
+1 💚	checkstyle	2m 20s		master passed
+1 💚	spotbugs	7m 42s		master passed
+1 💚	spotless	0m 52s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 10s		the patch passed
+1 💚	compile	8m 30s		the patch passed
+1 💚	javac	8m 30s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	2m 18s		the patch passed
-0 ⚠️	shellcheck	0m 0s	/results-shellcheck.txt	The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)
+1 💚	spotbugs	7m 47s		the patch passed
+1 💚	hadoopcheck	12m 17s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
-1 ❌	spotless	0m 8s		patch has 34 errors when running spotless:check, run spotless:apply to fix.
			_ Other Tests _
-1 ❌	asflicense	0m 21s	/results-asflicense.txt	The patch generated 1 ASF License warnings.
		66m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7566/25/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7566
Optional Tests	dupname asflicense codespell detsecrets shellcheck shelldocs spotless yamllint javac spotbugs checkstyle compile hadoopcheck hbaseanti
uname	Linux a23ce0bc9eee 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `0d236cd`
Default Java	Eclipse Adoptium-17.0.11+9
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7566/25/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	189 (vs. ulimit of 30000)
modules	C: hbase-annotations . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7566/25/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 shellcheck=0.8.0
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

ndimiduk · 2026-01-12T16:10:00Z

Okay team, I think this is ready for review. I'll delete the last commit that introduces breakage before merging. But here you can see that we appear to have feature parity with jenkins, using the nightlies server instead of ci-hbase for hosting build results.

ndimiduk · 2026-01-12T16:11:13Z

.github/workflows/yetus-general-check.yml

+          SUREFIRE_SECOND_PART_FORK_COUNT: "0.5C"
+          HADOOP_PROFILE: "3.0"
+          BRANCH_NAME: "${{ github.base_ref }}"
+          DEBUG: 'true'


Let's leave this enabled for a bit in case there are other issues that come up.

ndimiduk · 2026-01-12T16:12:09Z

.github/workflows/yetus-general-check.yml

+          BUILD_THREAD: "4"
+          SUREFIRE_FIRST_PART_FORK_COUNT: "0.5C"
+          SUREFIRE_SECOND_PART_FORK_COUNT: "0.5C"


No idea how to tune these values for an action runner.

The action runners are VMs with dedicated CPUs, and in my experience don't suffer from noisy neighbors like Jenkins executors do. I would probably do 2C to take full advantage of the CPUs.

ndimiduk · 2026-01-12T16:13:14Z

Would appreciate your review on this as well, @gmcdonald .

This comment has been minimized.

Sign in to view

ndimiduk changed the title ~~HBASE-29787 Move static checks to a Github Action~~ HBASE-29787 Run static checks to a Github Action Dec 19, 2025

This comment has been minimized.

Sign in to view

ndimiduk marked this pull request as ready for review December 19, 2025 18:09

ndimiduk requested review from Apache9, NihalJain, charlesconnell, petersomogyi and stoty December 19, 2025 18:10

Apache9 reviewed Dec 20, 2025

View reviewed changes

.github/workflows/yetus-general-check.yml Outdated Show resolved Hide resolved

ndimiduk added 11 commits January 12, 2026 14:26

HBASE-29787 Run Yetus General Checks as a GitHub Action

81aca72

remote path probably still needs hbase prefix

28d1e45

explicitly create remote path on nightlies before rsync

cfc43dc

try something else to fix build artifact urls

fe7f391

rsync with -no-o to preserve the more permissive ownership

889c9b7

enable verbose debugging

d0e83e8

conditionally define this robot function yetus bug?

15010e6

set BUILD_URL and BUILD_URL_ARTIFACTS from personality_globals

64fd95e

we need to override these after the githubactions robot sets them so that they point to our nightlies upload path.

make BUILD_URL_ARTIFACTS conditionally required

6a99d98

fix --no-o on rsync

57bbd4a

remove the extra slash

8d69881

ndimiduk force-pushed the 29787-gh-actions-static branch from ac1fe1c to cdbbdc1 Compare January 12, 2026 13:26

This comment has been minimized.

Sign in to view

ndimiduk added 3 commits January 12, 2026 14:36

remove debugging of nightlies

29d16fa

try fix hide old comments

b0b05c8

introduce some breakages

0d236cd

ndimiduk force-pushed the 29787-gh-actions-static branch from cdbbdc1 to 0d236cd Compare January 12, 2026 13:37

This comment has been minimized.

Sign in to view

ndimiduk marked this pull request as ready for review January 12, 2026 16:08

ndimiduk requested a review from Apache9 January 12, 2026 16:10

ndimiduk commented Jan 12, 2026

View reviewed changes

ndimiduk requested a review from gmcdonald January 12, 2026 16:13

HBASE-29787 Run Yetus General Checks as a GitHub Action #7566

Are you sure you want to change the base?

HBASE-29787 Run Yetus General Checks as a GitHub Action #7566

Conversation

ndimiduk commented Dec 19, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ndimiduk commented Dec 19, 2025

Uh oh!

Apache9 commented Dec 20, 2025

Uh oh!

Apache9 commented Dec 20, 2025

Uh oh!

Apache9 commented Dec 20, 2025

Uh oh!

Uh oh!

This comment has been minimized.

github-actions bot commented Jan 12, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Jan 12, 2026

Uh oh!

Apache-HBase commented Jan 12, 2026

Uh oh!

github-actions bot commented Jan 12, 2026

Uh oh!

Apache-HBase commented Jan 12, 2026

Uh oh!

ndimiduk commented Jan 12, 2026

Uh oh!

ndimiduk Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

ndimiduk Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

charlesconnell Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

ndimiduk commented Jan 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants