-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[feature] Add AWS sms client #3134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d36b496
to
dd0a426
Compare
@a-little-fool You mean I should check the code style and commit message, right? |
What I mean is that you can first run and check locally (according to the help documentation), so you don't have to push it up and make changes again. This might be more convenient, otherwise it would be like my PR I pushed it many times haha. |
Hi, there is also a part in the manager module of the backend that needs to be updated, and corresponding options also need to be added to the frontend if possible. You can refer to this PR #3135. |
hertzbeat-alerter/src/main/java/org/apache/hertzbeat/alert/service/impl/AwsSmsClientImpl.java
Outdated
Show resolved
Hide resolved
hertzbeat-alerter/src/main/java/org/apache/hertzbeat/alert/service/impl/AwsSmsClientImpl.java
Outdated
Show resolved
Hide resolved
LGTM!Thanks |
What's changed?
Add AWS sms client
#3111
Checklist
Looking for Feedback On: