HIVE-28801 Iceberg: Refactor HMS table parameter setting to be able to reuse #5676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
zratkai
force-pushed
the
HIVE-28801
branch
2 times, most recently
from
2bccf44 to
f0ea137
Compare
asf-ci-hive
added
tests failed
tests pending
tests unstable
and removed
tests pending
tests failed
labels
kasakrisz
reviewed
Mar 28, 2025
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HMSTablePropertyHelper.java
Outdated
Show resolved
Hide resolved
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HMSTablePropertyHelper.java
Show resolved
Hide resolved
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HMSTablePropertyHelper.java
Show resolved
Hide resolved
difin
reviewed
Mar 28, 2025
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
Outdated
Show resolved
Hide resolved
|
There are test failures with error like |
|
LGTM +1, pending tests and #5676 (comment) |
difin
approved these changes
Apr 4, 2025
asf-ci-hive
added
tests pending
tests passed
and removed
tests failed
tests pending
labels
deniskuzZ
reviewed
Apr 7, 2025
| } | ||
| } | ||
|
|
||
| public static void setSchema(Schema schema, Map<String, String> parameters, long maxHiveTablePropertySize) { |
There was a problem hiding this comment.
should we declare public methods at the top of class declaration?
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
… reuse Change-Id: I307f09032d1ed8ee5a6eea78394939d2de48b54b
|
basapuram-kumar
pushed a commit
to acceldata-io/hive
that referenced
this pull request
Jul 8, 2025
…to reuse (Zoltán Rátkai, reviewed by Denys Kuzmenko, Dmitriy Fingerman) Closes apache#5676, Iceberg #12461
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HIVE-28801 Iceberg: Refactor HMS table parameter setting to be able to reuse
Change-Id: I317cee162f1bc39ee9e385bd3ac82bea3414a06e
What changes were proposed in this pull request?
Refactoring HMS table parameter setting to be able to reuse
Why are the changes needed?
To be able to reuse existing code.
Does this PR introduce any user-facing change?
No.
Is the change a dependency upgrade?
No.
How was this patch tested?
Unit test.