HIVE-28146: Add positive event type filter to the HMS notification fe… #5694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dengzhhu653
reviewed
Mar 14, 2025
| for (String eventType : rqst.getEventTypeList()) { | ||
| parameterVals.add(eventType); | ||
| parameterBuilder.append(", java.lang.String para" + parameterVals.size()); | ||
| filterBuilder.append(" && eventType == para" + parameterVals.size()); |
There was a problem hiding this comment.
this should be || instead of &&?
There was a problem hiding this comment.
You are right. Let me modify the test case to address the same.
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
saihemanth-cloudera
force-pushed
the
hive-28146
branch
from
6656468 to
c268e93
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tch API
What changes were proposed in this pull request?
Added a new field 'eventTypeList' in the NotificationEventRequest
Why are the changes needed?
So that clients can request notificationEvents based on required event types.
Does this PR introduce any user-facing change?
No.
Is the change a dependency upgrade?
No.
How was this patch tested?
Local testing and added unit test for the same.