HIVE-28825: Support conversion of complex types to String #5702
Conversation
asf-ci-hive
added
tests pending
tests failed
and removed
tests pending
tests failed
labels
| @@ -0,0 +1,31 @@ | |||
| create table table1(id int, txt string, num int, flag string); | |||
There was a problem hiding this comment.
Could you please add some test cases where complex types are nested?
struct {
a map<string, array<int>>,
b struct { c decimal(10,3), d double}
}
There was a problem hiding this comment.
Added nested test in udf_to_string.q
| select md5(s) csum from (select cast(array(*) as string) s from table1) t; | ||
| select md5(s) csum from (select cast(array(*) as string) s from table2) t; |
There was a problem hiding this comment.
These tests pass a string to the md5 function. I don't think it is necessary to test it because we already have test for that in udf_md5.q
Please let me know if there is something else that these tests cover.
Do we want to support md5 with complex type parameter? I think it is out of scope of this patch.
There was a problem hiding this comment.
I have removed tests with md5.
| select cast(array(*) as string) from table1; | ||
| select cast(array(*) as string) from table2; |
There was a problem hiding this comment.
Could you please add these tests to udf_to_string.q file? I think we don't need a separate q file. WDYT?
There was a problem hiding this comment.
Added tests for complex types in udf_to_string.q
asf-ci-hive
added
tests pending
tests passed
and removed
tests failed
tests pending
labels
| SELECT CAST(NULL AS STRING) FROM src tablesample (1 rows); | ||
| SELECT CAST(NULL AS STRING) FROM alltypesorc tablesample (1 rows); | ||
|
|
||
| SELECT CAST(TRUE AS STRING) FROM src tablesample (1 rows); | ||
| SELECT CAST(TRUE AS STRING) FROM alltypesorc tablesample (1 rows); | ||
|
|
||
| SELECT CAST(CAST(1 AS TINYINT) AS STRING) FROM src tablesample (1 rows); | ||
| SELECT CAST(CAST(-18 AS SMALLINT) AS STRING) FROM src tablesample (1 rows); | ||
| SELECT CAST(-129 AS STRING) FROM src tablesample (1 rows); | ||
| SELECT CAST(CAST(-1025 AS BIGINT) AS STRING) FROM src tablesample (1 rows); | ||
| SELECT CAST(CAST(1 AS TINYINT) AS STRING) FROM alltypesorc tablesample (1 rows); | ||
| SELECT CAST(CAST(-18 AS SMALLINT) AS STRING) FROM alltypesorc tablesample (1 rows); | ||
| SELECT CAST(-129 AS STRING) FROM alltypesorc tablesample (1 rows); | ||
| SELECT CAST(CAST(-1025 AS BIGINT) AS STRING) FROM alltypesorc tablesample (1 rows); | ||
|
|
||
| SELECT CAST(CAST(-3.14 AS DOUBLE) AS STRING) FROM src tablesample (1 rows); | ||
| SELECT CAST(CAST(-3.14 AS FLOAT) AS STRING) FROM src tablesample (1 rows); | ||
| SELECT CAST(CAST(-3.14 AS DECIMAL(3,2)) AS STRING) FROM src tablesample (1 rows); | ||
| SELECT CAST(CAST(-3.14 AS DOUBLE) AS STRING) FROM alltypesorc tablesample (1 rows); | ||
| SELECT CAST(CAST(-3.14 AS FLOAT) AS STRING) FROM alltypesorc tablesample (1 rows); | ||
| SELECT CAST(CAST(-3.14 AS DECIMAL(3,2)) AS STRING) FROM alltypesorc tablesample (1 rows); | ||
|
|
||
| SELECT CAST('Foo' AS STRING) FROM src tablesample (1 rows); | ||
| SELECT CAST('Foo' AS STRING) FROM alltypesorc tablesample (1 rows); |
There was a problem hiding this comment.
Does the from clause relevant in these statements? It seem that we are casting constants.
Example:
SELECT CAST(CAST(-3.14 AS DOUBLE) AS STRING);
should also test GenericUDFToString.
Could you please confirm?
asf-ci-hive
added
tests pending
tests failed
and removed
tests passed
tests pending
tests failed
labels
|
What changes were proposed in this pull request?
Support conversion of complex types to String using
cast(<value> as string)(GenericUDFToString.java)Why are the changes needed?
Details in https://issues.apache.org/jira/browse/HIVE-28825
Does this PR introduce any user-facing change?
No, except for the new feature.
Is the change a dependency upgrade?
No
How was this patch tested?