Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-28842: Hive ACID: Compaction cleaner refactor #5705

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

deniskuzZ
Copy link
Member

@deniskuzZ deniskuzZ commented Mar 19, 2025

What changes were proposed in this pull request?

Code refactor, reuse utils methods to avoid code duplication

Why are the changes needed?

TechDept

Does this PR introduce any user-facing change?

No

Is the change a dependency upgrade?

No

How was this patch tested?

Jenkins

Copy link
Contributor

@okumin okumin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left only a minor comment

requestBuilder.setUser(ci.runAs);
requestBuilder.setTransactionId(0);

LockComponentBuilder lockCompBuilder = new LockComponentBuilder()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@okumin okumin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@deniskuzZ deniskuzZ changed the title Hive ACID: Compaction cleaner refactor HIVE-28842: Hive ACID: Compaction cleaner refactor Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants