HIVE-29277: Invalid index should return null for get_json_object #6144
+14
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
deniskuzZ
reviewed
Nov 5, 2025
| json = extract_json_withindex(json, indexList); | ||
| if (indexList.isEmpty()) { | ||
| // Return null if index is invalid. | ||
| return path.contains("[") ? null : json; |
Member
There was a problem hiding this comment.
could we refactor
if (indexList.size() > 0) {
json = extract_json_withindex(json, indexList);
} else if (path.indexOf('[') >= 0) {
return null; // index is invalid
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Return null for invalid index in
get_json_objectudf.Why are the changes needed?
Fix bug.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Add unit test.