HIVE-29305: Migrate from the AWS SDK for Java v1 to v2 #6167
Conversation
| // Do not create SecretCache here, it fails to initialize in non-aws aware environments. | ||
| private volatile SecretCache cache = null; | ||
| // Do not create cache here, it fails to initialize in non-aws aware environments. | ||
| private volatile LoadingCache<String, String> cache = null; |
There was a problem hiding this comment.
aws-secretsmanager-caching-java does not exist in v2. So we need to implement our own cache or use the v1 version.
asf-ci-hive
added
tests pending
tests passed
and removed
tests failed
tests pending
labels
|
|
was the hadoop migrated to aws sdk v2 as well? |
|
@deniskuzZ Yes, as far as I see the documentation and tickets, the migration has been completed. |
|
i used https://repo1.maven.org/maven2/software/amazon/awssdk/bundle/2.26.19/bundle-2.26.19.jar with Hive-4.2 and it works without any code changes. |
|
@deniskuzZ How did you verify this? Isn't that because it's using |
was using docker with s3 setup: #6215, but indeed |
|
@deniskuzZ If so, it's working with v1. If we can use |
3 participants
What changes were proposed in this pull request?
Migrate from the AWS SDK for Java v1 to v2
Why are the changes needed?
AWS SDK for Java v1.x will reach EOL on December 31, 2025: https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-java-v1-x-on-december-31-2025/
Does this PR introduce any user-facing change?
No
How was this patch tested?
I just ran the existing tests.