HIVE-29305: Migrate from the AWS SDK for Java v1 to v2 #6167
+58
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryukobayashi
commented
Nov 5, 2025
| // Do not create SecretCache here, it fails to initialize in non-aws aware environments. | ||
| private volatile SecretCache cache = null; | ||
| // Do not create cache here, it fails to initialize in non-aws aware environments. | ||
| private volatile LoadingCache<String, String> cache = null; |
Contributor
Author
There was a problem hiding this comment.
aws-secretsmanager-caching-java does not exist in v2. So we need to implement our own cache or use the v1 version.
asf-ci-hive
added
tests pending
tests passed
and removed
tests failed
tests pending
labels
|
Member
|
was the hadoop migrated to aws sdk v2 as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Migrate from the AWS SDK for Java v1 to v2
Why are the changes needed?
AWS SDK for Java v1.x will reach EOL on December 31, 2025: https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-java-v1-x-on-december-31-2025/
Does this PR introduce any user-facing change?
No
How was this patch tested?
I just ran the existing tests.