HIVE-29333: Ignore NoClassDefFoundError when registering Iceberg UDFs in FunctionRegistry #6214
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in FunctionRegistry
|
Member
|
@thomasrebele, could you please attach the stacktrace |
Contributor
Author
|
Unfortunately I've forgot to save the stacktrace, and I've also forgot which test caused the problem. If I encounter it again, I'll add the stacktrace. It happened at least twice in the last three months, so it's quite likely to happen again. |
zabetak
reviewed
Nov 28, 2025
| system.registerGenericUDF("iceberg_zorder", | ||
| (Class<? extends GenericUDF>) Class.forName("org.apache.iceberg.mr.hive.udf.GenericUDFIcebergZorder")); | ||
| } catch (ClassNotFoundException e) { | ||
| } catch (ClassNotFoundException | NoClassDefFoundError e) { |
Member
There was a problem hiding this comment.
In general, we should not try to catch instances of Error in application code. Moreover, the Javadoc of NoClassDefFoundError writes the following:
* The searched-for class definition existed when the currently
* executing class was compiled, but the definition can no longer be
* found.If we get this exception then it seems more like an IDE config issue rather than something that we need to fix here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Ignore NoClassDefFoundError in addition to the already ignored ClassNotFoundException.
Why are the changes needed?
A NoClassDefFoundError is sometimes thrown when debugging tests in Intellij IDEA.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manually while debugging a qfile test with Intellij IDEA.