feat(catalog): Standardize Catalog create table function #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 8, 2025
zeroshade
force-pushed
the
catalog-create-table
branch
from
984351a to
b384c0f
Compare
Fokko
reviewed
Jan 10, 2025
kevinjqliu
approved these changes
Jan 13, 2025
Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com>
|
@Fokko any further comments? |
Fokko
approved these changes
Jan 15, 2025
| return &metadataV1{ | ||
| commonMetadata: common, | ||
| Schema: freshSchema, | ||
| Partition: slices.Collect(freshPartitions.Fields()), |
There was a problem hiding this comment.
In PyIceberg we decided to upgrade everything to V2 internally, and do the V1-specific things when serializing/deserializing. This is not a blocker for this PR.
|
Thanks @zeroshade 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a CreateTable function to the
Cataloginterface, standardizing the implementation that was initially created by #146 so that it isn't specific to the REST catalog and can be implemented by any catalog.This also requires adding the
AssignFresh*IDsfunctions so that the REST catalog implementation is correctly re-assigning IDs as other implementations do.