feat(catalog): Propagate ctx from catalog interface through call stack #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroshade
reviewed
Jan 28, 2025
zeroshade
reviewed
Jan 28, 2025
curtisr7
force-pushed
the
rgc/catalog-ctx
branch
2 times, most recently
from
443bbe6 to
53ddb06
Compare
zeroshade
approved these changes
Jan 29, 2025
zeroshade
changed the title
curtisr7
force-pushed
the
rgc/catalog-ctx
branch
from
82080f5 to
1525dd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general we should pass
context.Contextthrough call path rather than creatingcontext.Backgroundat random places.I made this change in response to this comment. I'll fix the original problem in a subsequent PR.