Nessie REST API Support for Namespace Operations #297
+306
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroshade
reviewed
Feb 10, 2025
Comment on lines
+1029
to
+1033
| type namespaceItem struct { | ||
| Type string `json:"type"` | ||
| ID string `json:"id"` | ||
| Elements []string `json:"elements"` | ||
| } |
There was a problem hiding this comment.
is this something in the actual REST API spec? or is it unique to Nessie's implementation? If this is unique to Nessie, then I would not be in favor of adding this to the REST catalog implementation
zeroshade
reviewed
Feb 10, 2025
Comment on lines
1062
to
1065
| type payload struct { | ||
| Remove []string `json:"removals"` | ||
| Updates iceberg.Properties `json:"updates"` | ||
| PropertyUpdates iceberg.Properties `json:"propertyUpdates"` | ||
| PropertyRemovals []string `json:"propertyRemovals,omitempty"` | ||
| } |
There was a problem hiding this comment.
Isn't this change incompatible with the REST API?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds support for using Apache Nessie as a REST catalog by implementing the Nessie API paths for namespace operations. The changes ensure compatibility with Nessie API v0.102.4.
Changes
Modified
catalog/rest.goUpdated namespace-related functions to align with Nessie API paths:
Added
context.goGetRefFromContextandWithReffunctions to handle reference passing through contextTesting
I had to modify path and structure of test cases to make it work with nessie
All Test Cases are passing