nit

apache · Sep 16, 2024 · e679ed8 · e679ed8
1 parent 28616c1
commit e679ed8
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/pyiceberg/table/__init__.py b/pyiceberg/table/__init__.py
@@ -461,7 +461,7 @@ def append(self, df: pa.Table, snapshot_properties: Dict[str, str] = EMPTY_DICT)
                 for data_file in data_files:
                     append_files.append_data_file(data_file)
 
-    def _build_partition_predicate(self, partition_records: List[Record]) -> BooleanExpression:
+    def _build_partition_predicate(self, partition_records: Set[Record]) -> BooleanExpression:
         partition_spec = self.table_metadata.spec()
         schema = self.table_metadata.schema()
         partition_fields = [schema.find_field(field.source_id).name for field in partition_spec.fields]
@@ -523,8 +523,8 @@ def dynamic_partition_overwrite(self, df: pa.Table, snapshot_properties: Dict[st
             )
         )
 
-        overlapping_partitions = [data_file.partition for data_file in data_files]
-        delete_filter = self._build_partition_predicate(partition_records=overlapping_partitions)
+        partitions_to_overwrite = {data_file.partition for data_file in data_files}
+        delete_filter = self._build_partition_predicate(partition_records=partitions_to_overwrite)
         self.delete(delete_filter=delete_filter)
 
         manifest_merge_enabled = property_as_bool(