Bug Fix: Glue and Hive catalog return only Iceberg tables #1145
Conversation
mark-major
force-pushed
the
filter-out-non-iceberg-tables
branch
from
cbe2ff6
to
cfb1d45
Compare
mark-major
changed the title
There was a problem hiding this comment.
Hi @mark-major thank you for putting together this PR. The tests for the hive and glue catalogs seem to prove that your implementation is working 💯
I've left a question about the dynamodb implementation, and a nit suggestion, please let me know your thoughts!
| @@ -393,7 +393,7 @@ def drop_namespace(self, namespace: Union[str, Identifier]) -> None: | |||
| raise NoSuchNamespaceError(f"Database does not exist: {database_name}") from e | |||
|
|
|||
| def list_tables(self, namespace: Union[str, Identifier]) -> List[Identifier]: | |||
| """List tables under the given namespace in the catalog (including non-Iceberg tables). | |||
| """List Iceberg tables under the given namespace in the catalog. | |||
There was a problem hiding this comment.
I noticed that we only updated the docstring here, without a change in the code.
Does Dynamodb already only return Iceberg tables?
There was a problem hiding this comment.
It was quite a long time since I have worked on this, but if I recall correctly then yes, DynamoDB returned only Iceberg tables.
Co-authored-by: Sung Yun <107272191+sungwy@users.noreply.github.com>
There was a problem hiding this comment.
Thank you again for working on this @mark-major ! I've confirmed that this behavior is consistent with Java
sungwy
changed the title
Closes #314
Glue and Hive catalogs
list_tables()method filters for Iceberg tables.