Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Docstrings to pyiceberg/table/__init__.py #1189

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Add Docstrings to pyiceberg/table/__init__.py #1189

merged 1 commit into from
Sep 20, 2024

Conversation

sungwy
Copy link
Collaborator

@sungwy sungwy commented Sep 20, 2024 •
edited
Loading

kevinjqliu
kevinjqliu approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding more docs

@sungwy
Copy link
Collaborator Author

sungwy commented Sep 20, 2024

Thanks for the review @kevinjqliu 🙂

@sungwy sungwy merged commit 1d9570d into apache:main Sep 20, 2024
8 checks passed
@sungwy sungwy deleted the docstrings branch September 20, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinjqliu kevinjqliu kevinjqliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sungwy @kevinjqliu