Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support python 3.12 in poetry #1192

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Conversation

kevinjqliu
Copy link
Contributor

Allow python 3.12 to run poetry.

Changed to use caret requirements, same logic. Greater than or equal to 3.8, less than 3.13 which is currently in pre-release.
Changed from <= to < because sometimes, 3.12.6 doesn't match <= 3.12, <3.13 is fixes that

https://python-poetry.org/docs/dependency-specification/#caret-requirements
https://www.python.org/doc/versions/

Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@@ -69,7 +69,7 @@ jobs:
env:
# Ignore 32 bit architectures
CIBW_ARCHS: "auto64"
CIBW_PROJECT_REQUIRES_PYTHON: ">=3.8,<=3.12"
CIBW_PROJECT_REQUIRES_PYTHON: ">=3.8,<3.13"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sungwy sungwy merged commit a17ba56 into apache:main Sep 23, 2024
8 checks passed
@kevinjqliu kevinjqliu deleted the kevinjqliu/support-3.12 branch September 23, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants