Skip to content

Fix for Timestamp and Date Conversion to Long in Iceberg Records #11841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kakavenkat
Copy link

This PR addresses the issue of timestamps and dates being converted into long values (epoch time in microseconds) when Spark data is written into Iceberg records.

Copy link
Member

@RussellSpitzer RussellSpitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how this fixes any problems and I'm pretty sure it would break our current writers.

Copy link

github-actions bot commented Feb 2, 2025

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 2, 2025
@Fokko
Copy link
Contributor

Fokko commented Feb 3, 2025

I agree with @RussellSpitzer and go ahead and close this. Feel free to reopen this @kakavenkat including tests to demonstrate the issue.

@Fokko Fokko closed this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants