Skip to content

fix(go): update stats field and its deserialization logic to align with rust SDK #3032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chengxilo wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix(go): update stats field and its deserialization logic to align with rust SDK #3032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
097595c
fix(go): update stats field to align with rust SDK
chengxilo Mar 26, 2026
c7ced34
chore(go): improve test coverage
chengxilo Mar 26, 2026
d3f5b66
Merge branch 'master' into update-stats
chengxilo Mar 27, 2026
c458b39
Merge branch 'master' into update-stats
chengxilo Mar 31, 2026
5809769
Merge branch 'master' into update-stats
hubcio Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions examples/go/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ github.com/avast/retry-go/v5 v5.0.0 h1:kf1Qc2UsTZ4qq8elDymqfbISvkyMuhgRxuJqX2NHP
github.com/avast/retry-go/v5 v5.0.0/go.mod h1://d+usmKWio1agtZfS1H/ltTqwtIfBnRq9zEwjc3eH8=
github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
github.com/google/go-cmp v0.7.0 h1:wk8382ETsv4JYUZwIsn6YpYiWiBsYLSJiTsyBybVuN8=
github.com/google/go-cmp v0.7.0/go.mod h1:pXiqmnSA92OHEEa9HXL2W4E7lf9JzCmGVUdgjX3N/iU=
github.com/google/uuid v1.6.0 h1:NIvaJDMOsjHA8n1jAhLSgzrAzy1Hgr+hNrb57e+94F0=
github.com/google/uuid v1.6.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
github.com/klauspost/compress v1.18.0 h1:c/Cqfb0r+Yi+JtIEq73FWXVkRonBlf0CRNYc8Zttxdo=
Expand Down
90 changes: 0 additions & 90 deletions foreign/go/binary_serialization/stats_serializer.go
View file
Open in desktop

This file was deleted.

127 changes: 0 additions & 127 deletions foreign/go/binary_serialization/stats_serializer_test.go
View file
Open in desktop

This file was deleted.

7 changes: 3 additions & 4 deletions foreign/go/client/tcp/tcp_utilities.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
package tcp

import (
binaryserialization "github.com/apache/iggy/foreign/go/binary_serialization"
iggcon "github.com/apache/iggy/foreign/go/contracts"
"github.com/apache/iggy/foreign/go/internal/command"
)
Expand All @@ -29,10 +28,10 @@ func (c *IggyTcpClient) GetStats() (*iggcon.Stats, error) {
return nil, err
}

stats := &binaryserialization.TcpStats{}
err = stats.Deserialize(buffer)
s := &iggcon.Stats{}
err = s.UnmarshalBinary(buffer)

return &stats.Stats, err
return s, err
}

func (c *IggyTcpClient) Ping() error {
Expand Down
Loading
Loading