Skip to content

fix(cli): Ensure home directory exists when writing contexts #3069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pauliyobo wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −1
Open

fix(cli): Ensure home directory exists when writing contexts #3069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .typos.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ bimap = "bimap"
flate = "flate"
# Valid Rust compression crate name
flate2 = "flate2"
# valid rust crate name
writeable = "writeable"
# Valid project-specific technical acronym
bais = "bais"
# Legitimate abbreviation for "Strategy" (e.g. pollingStrat)
Expand Down
3 changes: 2 additions & 1 deletion core/cli/src/commands/binary_context/common.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,6 @@ impl ContextManager {
let mut new_contexts = cs.contexts.clone();
new_contexts.insert(name.to_string(), config);

self.context_rw.ensure_iggy_home_exists().await?;
self.context_rw
.write_contexts(new_contexts.clone())
.await
Expand Down Expand Up @@ -289,6 +288,7 @@ impl ContextReaderWriter {
contexts_path.display()
))?;

self.ensure_iggy_home_exists().await?;
tokio::fs::write(&contexts_path, contents).await?;
Self::set_owner_only_permissions(&contexts_path).await?;
}
Expand Down Expand Up @@ -320,6 +320,7 @@ impl ContextReaderWriter {
}

pub async fn write_active_context(&self, context_name: &str) -> Result<()> {
self.ensure_iggy_home_exists().await?;
let maybe_active_context_path = self.active_context_path();

if let Some(active_context_path) = maybe_active_context_path {
Expand Down