Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat][Spark] Add Neo4j importer #243

Merged
merged 9 commits into from
Dec 27, 2023
Merged

[Feat][Spark] Add Neo4j importer #243

merged 9 commits into from
Dec 27, 2023

Conversation

jasinliu
Copy link
Contributor

@jasinliu jasinliu commented Oct 3, 2023

Proposed changes

Provide a basic user defined json config to import neo4j.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Related issue#241

@acezen
Copy link
Contributor

acezen commented Dec 27, 2023

hi, @jasinliu, you may need to rebase to the latest commit and we can merge the change first.

@jasinliu jasinliu requested a review from acezen December 27, 2023 04:58
@acezen acezen changed the title [Feat][Spark] Neo4j importer [Feat][Spark] Add Neo4j importer Dec 27, 2023
@acezen acezen merged commit d8526b9 into apache:main Dec 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants