Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIVY-988] Support for escaping backtick from spark-submit arguments #417

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

s0nskar
Copy link

@s0nskar s0nskar commented Aug 26, 2023

What changes were proposed in this pull request?

Fixes - #415

Adding support for escaping backticks from spark-submit arguments.

  • This feature will be behind a flag livy.server.escapeBackTicks (default: false)
  • This also handles the case where the user is already escaping backtick and livy won't perform double escaping.

How was this patch tested?

  • Added unit test for escape backticks function.

@s0nskar
Copy link
Author

s0nskar commented Aug 26, 2023

cc: @pralabhkumar

@s0nskar s0nskar changed the title Support for escaping backtick from spark-submit arguments [Livy-988] Support for escaping backtick from spark-submit arguments Aug 30, 2023
@pralabhkumar
Copy link
Contributor

Hi @s0nskar . I am looking into this .

@pralabhkumar
Copy link
Contributor

@s0nskar Build is failing because of checkstyle issue , please look into fixing this.

@s0nskar s0nskar changed the title [Livy-988] Support for escaping backtick from spark-submit arguments [LIVY-988] Support for escaping backtick from spark-submit arguments Sep 11, 2023
@RonZhang724
Copy link

@pralabhkumar My company uses AWS EMR for data processing, and EMR uses livy for job submissions. We ran into issue with backticks recently because the content in backticks gets removed.

Would you mind following up on this PR and include it in the future releases?

@s0nskar
Copy link
Author

s0nskar commented Apr 4, 2024

@pralabhkumar PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants