Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testing with Python3 #424

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Fix testing with Python3 #424

merged 1 commit into from
Oct 24, 2023

Conversation

mvanderlee
Copy link
Contributor

What changes were proposed in this pull request?

Fix print statement in tests to be Python 2 and Python 3 compatible.
#408

Created an account in JIRA, waiting for approval so I can submit a ticket there as well.

How was this patch tested?

Using the docker build for Spark 3

docker run --rm -it -v $(pwd):/workspace -v $HOME/.m2:/root/.m2 livy-ci mvn package -Pspark3 

@codecov-commenter
Copy link

Codecov Report

Merging #424 (5271a3a) into master (8b2e29f) will decrease coverage by 36.91%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master     #424       +/-   ##
=============================================
- Coverage     65.48%   28.58%   -36.91%     
+ Complexity      950      378      -572     
=============================================
  Files           103      103               
  Lines          6062     6062               
  Branches        916      916               
=============================================
- Hits           3970     1733     -2237     
- Misses         1541     3976     +2435     
+ Partials        551      353      -198     

see 86 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ksumit ksumit merged commit 024efa5 into apache:master Oct 24, 2023
3 checks passed
@ksumit
Copy link
Contributor

ksumit commented Oct 24, 2023

Thanks @mvanderlee for your contribution.

jimenefe pushed a commit to onedot-data/incubator-livy that referenced this pull request Oct 15, 2024
Fix print statement in tests to be Python 2 and Python 3 compatible. apache#408
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants