fix: parse timestamp from the name of data dir for gc instead of the last update time #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
empiredan
force-pushed
the
use-timestamp-for-dir-gc
branch
from
d88b67a to
aa5e062
Compare
acelyc111
reviewed
Nov 3, 2023
acelyc111
previously approved these changes
Nov 6, 2023
acelyc111
approved these changes
Nov 7, 2023
GehaFearless
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1673
It's found that sometimes the data directories of replicas are removed
immediately after they are renamed with postfixes
.err/.gar, thoughactually both of
gc_disk_error_replica_interval_secondsandgc_disk_garbage_replica_interval_secondshave been configuredwith at least one day.
The reason is that the base time for expiration time is the last write
time, that is,
st_mtimewithinstruct statreturned bystat().Once a long time has passed since the last write time, the data directory
will be removed immediately after it is renamed with postfixes
.err/.gar.To fix this problem, just use the timestamp within the directory name as
the base time that is generated when the data directory is renamed with
postfixes
.err/.gar. The last update time would be used iff the timestampis NOT found within the directory name.